[Cadence 1.0] Optionally check atree storage health before migration #5591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #5591 +/- ##
==========================================================
+ Coverage 55.91% 57.30% +1.39%
==========================================================
Files 1049 817 -232
Lines 103170 83085 -20085
==========================================================
- Hits 57686 47614 -10072
+ Misses 41096 31726 -9370
+ Partials 4388 3745 -643
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fxamacker
reviewed
Mar 27, 2024
Co-authored-by: Faye Amacker <33205765+fxamacker@users.noreply.github.com>
fxamacker
approved these changes
Mar 27, 2024
Comment on lines
+286
to
+289
| accountBasedMigration := migrationConstructor( | ||
| // Only check storage health before the first migration | ||
| checkStorageHealthBeforeMigration && index == 0, | ||
| ) |
SupunS
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards onflow/cadence#3192
The atree storage health check after the migration might error because the input was already unhealthy.
Optionally check the health before the migration, and do not error if the output is unhealthy when the input was already unhealthy.